Linting and other fixes + changelog

cs3org · Jul 31, 2020 · 9592157 · 9592157
1 parent 28d8d82
commit 9592157
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/changelog/unreleased/appprovider-fixes.md b/changelog/unreleased/appprovider-fixes.md
@@ -0,0 +1,7 @@
+Enhancement: Refactor AppProvider workflow
+
+Simplified the app-provider configuration: storageID is worked out
+automatically and UIURL is suppressed for now.
+Implemented the new gRPC protocol from the gateway to the appprovider.
+
+https://github.com/cs3org/reva/pull/1035
diff --git a/internal/grpc/services/gateway/appprovider.go b/internal/grpc/services/gateway/appprovider.go
@@ -26,10 +26,10 @@ import (
 	rpc "github.com/cs3org/go-cs3apis/cs3/rpc/v1beta1"
 	provider "github.com/cs3org/go-cs3apis/cs3/storage/provider/v1beta1"
 	storageprovider "github.com/cs3org/go-cs3apis/cs3/storage/provider/v1beta1"
-	tokenpkg "github.com/cs3org/reva/pkg/token"
 	"github.com/cs3org/reva/pkg/errtypes"
 	"github.com/cs3org/reva/pkg/rgrpc/status"
 	"github.com/cs3org/reva/pkg/rgrpc/todo/pool"
+	tokenpkg "github.com/cs3org/reva/pkg/token"
 	"github.com/pkg/errors"
 )
 
@@ -94,11 +94,11 @@ func (s *svc) OpenFileInAppProvider(ctx context.Context, req *gateway.OpenFileIn
 		}, nil
 	}
 
-    // build the appProvider specific request with the required extra info that has been obtained
+	// build the appProvider specific request with the required extra info that has been obtained
 	appProviderReq := &providerpb.OpenFileInAppProviderRequest{
 		ResourceInfo: fileInfo,
-		ViewMode: req.ViewMode,
-		AccessToken: accessToken
+		ViewMode:     req.ViewMode,
+		AccessToken:  accessToken,
 	}
 
 	res, err := appProviderClient.OpenFileInAppProvider(ctx, appProviderReq)