Skip to content

Commit

Permalink
fix: Update make commands to use go install for packages (#2747)
Browse files Browse the repository at this point in the history
  • Loading branch information
KarthikSundar2002 authored Apr 19, 2022
1 parent 8b95ed7 commit d140810
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ test-go-version:
# for manual building only
deps:
cd /tmp && rm -rf golangci-lint && git clone --quiet -b 'v1.42.1' --single-branch --depth 1 https://github.com/golangci/golangci-lint &> /dev/null && cd golangci-lint/cmd/golangci-lint && go install
cd /tmp && go get golang.org/x/tools/cmd/goimports
cd /tmp && go install golang.org/x/tools/cmd/goimports@latest

build-ci: off
go build -ldflags ${CI_BUILD_FLAGS} -o ./cmd/revad/revad ./cmd/revad
Expand Down
7 changes: 7 additions & 0 deletions changelog/unreleased/update-makefile.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Bugfix: Updates Makefile according to latest go standards

Earlier, we were using go get to install packages.
Now, we are using go install to install packages

https://github.com/cs3org/reva/issues/2675
https://github.com/cs3org/reva/pull/2747

0 comments on commit d140810

Please sign in to comment.