-
Notifications
You must be signed in to change notification settings - Fork 112
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
5 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
Bugfix: fix shares for external accounts | ||
Bugfix: Drop assumptions about user types when dealing with shares | ||
|
||
We may have external accounts with regular usernames (and with null uid): | ||
This patch decorates such usernames when storing them as Grantee in a share, | ||
such that when a share is retrieved, permissions are checked correctly. | ||
We may have external accounts with regular usernames (and with null uid), | ||
therefore the current logic to heuristically infer the user type from | ||
a grantee's username is broken. This PR removes those heuristics and | ||
requires the upper level to resolve the user type. | ||
|
||
https://github.com/cs3org/reva/pull/4849 |