Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read metrics from file (v2) #1118

Merged
merged 43 commits into from
Sep 14, 2020
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
5393f65
Configuration for metrics.
Jul 14, 2020
7783939
Dummy (test) driver implementation.
Jul 14, 2020
e7f2c0c
JSON metrics data file driver implementation.
Jul 14, 2020
8c25641
Metrics now uses data driver to access the actual metrics data.
Jul 14, 2020
0935163
deleted
Jul 14, 2020
db1fc17
New configuration for metrics.
Jul 14, 2020
c28411c
Changed package name, dummy driver struct name.
Jul 14, 2020
dac5a4f
Changed package name.
Jul 14, 2020
256b4af
Changed package name.
Jul 14, 2020
0eaecaf
Struct name changed to please hound bot.
Jul 14, 2020
51c6b14
Moved.
Jul 14, 2020
81a59e0
Rebase on SysInfo metrics
Jul 14, 2020
7bb316a
Fixed unnecessary conversion.
Jul 14, 2020
db498a9
Changelog added.
Jul 15, 2020
55ce5a9
Fixed: custom json file location not used.
Jul 15, 2020
c3b0242
Use sharedconfig instead.
Aug 25, 2020
3616aec
Does not need config.
Aug 25, 2020
3e503b9
Read file location from sharedconfig.
Aug 25, 2020
cf0eac5
Add metrics data driver type, location.
Aug 25, 2020
2f86b9b
Self initialize and periodic metrics data recording. Use sharedconfig.
Aug 25, 2020
5e60a12
Metrics conf moved to shared block.
Aug 25, 2020
1059a7a
Use driver type dummy by default.
Aug 25, 2020
9d1d53f
Fixed error check.
Aug 25, 2020
29f220a
Fixed title.
Aug 25, 2020
db62bc1
Reset sharedconf. Metrics does not use it.
Sep 4, 2020
c271c33
Add metrics drivers to loader.
Sep 4, 2020
e3f47c5
Add metrics service to loader.
Sep 4, 2020
6191a44
Config for metrics.
Sep 4, 2020
e16eb4a
Drivers register themselfes.
Sep 4, 2020
93180dc
New metrics service.
Sep 4, 2020
c418d20
Driver register.
Sep 4, 2020
f9b3103
Use register to get configured driver.
Sep 4, 2020
e419e36
Moved to dedicated namespace.
Sep 4, 2020
e6a14f9
Changelog added.
Sep 4, 2020
ab30488
Renamed.
Sep 4, 2020
6aa7da8
New parameter: metrics_record_interval
Sep 4, 2020
69d8a66
Init returns error.
Sep 4, 2020
66cd435
Init returns error.
Sep 4, 2020
c6bbced
Fix missing service line.
Sep 9, 2020
1f8b376
Load specific drivers in pkg loader.
Sep 9, 2020
375b588
Remove prefix.
Sep 9, 2020
3cf7ae2
Remove prefix.
Sep 9, 2020
473da68
Clean up.
Sep 9, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed: custom json file location not used.
Antoon Prins committed Sep 9, 2020
commit 55ce5a95220c03101d155853a3938a7d11a4f66e
4 changes: 3 additions & 1 deletion pkg/metrics/config/config.go
Original file line number Diff line number Diff line change
@@ -32,6 +32,8 @@ func (c *Config) Init() {
}
if c.MetricsDataDriverType == "json" {
// default values
c.MetricsDataLocation = "/var/tmp/reva/metrics/metricsdata.json"
if c.MetricsDataLocation == "" {
c.MetricsDataLocation = "/var/tmp/reva/metrics/metricsdata.json"
}
}
}