Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: added ocm invitation workflow commands #1558

Merged
merged 4 commits into from
Mar 18, 2021
Merged

cli: added ocm invitation workflow commands #1558

merged 4 commits into from
Mar 18, 2021

Conversation

jimil749
Copy link
Contributor

Fixes #1149

This PR adds 2 cli commands:

  • ocm-invite-generate: to generate an invitation token (to be executed by originator)
  • ocm-invite-forward: to forward the invitation token to the mesh provider (to be executed by recipient)

Signed-off-by: Jimil Desai [email protected]

@jimil749 jimil749 requested a review from labkode as a code owner March 16, 2021 19:45
@jimil749
Copy link
Contributor Author

@ishank011 Can you take a look?

Copy link
Contributor

@ishank011 ishank011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jimil. Looks good, just one comment

Token: *token,
}

providerInfo, err := client.GetInfoByDomain(ctx, &ocmprovider.GetInfoByDomainRequest{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the RPC status from this call

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do! 👍

Signed-off-by: Jimil Desai <[email protected]>
Signed-off-by: Jimil Desai <[email protected]>
Signed-off-by: Jimil Desai <[email protected]>
@jimil749
Copy link
Contributor Author

@ishank011 I have added the rpc status. Please take a look!

@ishank011 ishank011 merged commit 0061907 into cs3org:master Mar 18, 2021
@jimil749 jimil749 deleted the ocm-invitation-workflow branch March 18, 2021 11:12
ffurano pushed a commit to ffurano/reva that referenced this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CLI commands for OCM invitation workflow
2 participants