-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application passwords CLI commands #1743
Conversation
…generation for small strength
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gmgigi96. I added a few comments
Can you also add the usage of these generated passwords in the description? You'll have to start the appauth auth driver and update the registry rules like this https://github.com/cs3org/reva/blob/master/examples/storage-references/gateway.toml#L18 https://github.com/cs3org/reva/blob/master/examples/storage-references/storage-public.toml#L11-L15 |
Updated, let me know if it is ok |
@gmgigi96 looks good. But I meant that you could use the created password and show that it can only be used to access the resources present in the scope. For example
Also, can you add a new toml file to |
Thanks @ishank011, I will make the changes this afternoon |
Related to #1719
This PR add the commands
token-list
,token-remove
andtoken-create
to manage the application passwords.Multiple share and path options are possible:
(
token-list
also support some flags to filter the output list, like show only expired, show all, filter by label, as well as long and short print)Example: