Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Nextcloud storage driver #1863

Merged
merged 15 commits into from
Aug 16, 2021

Conversation

michielbdejong
Copy link
Contributor

Fixes #1862.

@michielbdejong michielbdejong requested a review from labkode as a code owner July 2, 2021 10:43
@michielbdejong
Copy link
Contributor Author

Ah, I see quite a few lint errors from Hound and also a few in make lint, will attend to them!

@michielbdejong michielbdejong marked this pull request as draft July 2, 2021 10:52
@michielbdejong michielbdejong marked this pull request as ready for review July 2, 2021 13:33
@michielbdejong
Copy link
Contributor Author

Hm, CI shows:
FAIL github.com/cs3org/reva/pkg/storage/fs/nextcloud [build failed]

@michielbdejong
Copy link
Contributor Author

Combining https://github.com/michielbdejong/reva/blob/nextcloud-storage-driver/.drone.star#L23 with https://github.com/michielbdejong/reva/blob/nextcloud-storage-driver/.drone.star#L154, I think the way to reproduce this error locally would be make ci.

When I do that on Mac, I get a library not found for -lcrt0.o error instead. I think that was something to do with dynamic vs static binding. I'll try out what happens when I run make ci on Ubuntu.

@michielbdejong
Copy link
Contributor Author

Testing this now on an Ubuntu VPS. First, seeing if I can get make ci to work in the main branch. Then I'll try in my branch.

@michielbdejong
Copy link
Contributor Author

Ah, now I found something:

go test github.com/cs3org/reva/pkg/storage/fs/nextcloud
# github.com/cs3org/reva/pkg/storage/fs/nextcloud_test [github.com/cs3org/reva/pkg/storage/fs/nextcloud.test]
pkg/storage/fs/nextcloud/nextcloud_test.go:64:13: undefined: nextcloud.NewNextcloudStorageDriver
pkg/storage/fs/nextcloud/nextcloud_test.go:64:50: undefined: nextcloud.NextcloudStorageDriverConfig
FAIL	github.com/cs3org/reva/pkg/storage/fs/nextcloud [build failed]
FAIL

@michielbdejong
Copy link
Contributor Author

@labkode can you review this when you have a moment, please?

@labkode
Copy link
Member

labkode commented Aug 16, 2021

Hi @michielbdejong this is a good starting point, we can merge this one and iteratively working on it.

@labkode labkode merged commit 62e7a66 into cs3org:master Aug 16, 2021
labkode added a commit that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Nextcloud storage driver
2 participants