[Tests-Only] Adjust expected failures after commit id update #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasson99
force-pushed
the
bumpCommitId-2021-08-18
branch
from
6048f17 to
f601458
Compare
|
#1963 should be merged first |
jasson99
force-pushed
the
bumpCommitId-2021-08-18
branch
from
f601458 to
94c274c
Compare
|
@jasson99 the other PR was merged. You can rebase this. |
jasson99
force-pushed
the
bumpCommitId-2021-08-18
branch
from
014135d to
8309156
Compare
4 tasks
jasson99
force-pushed
the
bumpCommitId-2021-08-18
branch
from
7a63f60 to
9311d87
Compare
jasson99
changed the title
phil-davis
previously approved these changes
Aug 23, 2021
|
@ishank011 this is ready to merge - gets the tests right up-to-date. |
|
@labkode this is an easy merge. |
|
@ishank011 @labkode any chance to merge? |
|
@ishank011 @labkode ping |
jasson99
force-pushed
the
bumpCommitId-2021-08-18
branch
from
9311d87 to
5ab1b93
Compare
phil-davis
approved these changes
Aug 30, 2021
|
This has been rebased and is ready to merge. |
1 task
labkode
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The related issue is "Implement expiration date for shares"
The scenarios related to that issue had ended up in a couple of different places. This PR puts the scenarios together in the expected-failures file in 3 sections, for user, group and public link shares. This should make it easier when a developer starts to implement this some day.
And bump the core commit id.
Also, the
skipOnOcisfilter tag is also added in the drone.star fileRelated Issue
How Has This Been Tested?
CI
Types of changes
Checklist: