Fail initialization if app is unsupported #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
glpatcern
force-pushed
the
appprovider-patch
branch
2 times, most recently
from
1ea182f to
3b78a63
Compare
As the frontend uses a separate tab, the folderurl argument becomes less relevant and WOPI will hide its breadcrumb when missing
glpatcern
force-pushed
the
appprovider-patch
branch
from
3b78a63 to
d35480a
Compare
labkode
approved these changes
Sep 7, 2021
|
@glpatcern if this is ready just mark the PR as "Ready for Review" so it moves out of draft state. |
|
Indeed, it can be merged right away - then we still have your patches Hugo ;-) |
refs
added a commit
to refs/reva
that referenced
this pull request
Sep 8, 2021
spaces: refactor decomposedfs spaces related code into spaces.go spaces: move list spaces to the new spaces.go file spaces: move private create space to the new spaces.go file space: spaces can have duplicated names space: fix linter space: uint conversions linter: file header linter: change receiver name linter: space out comments spaces: refactor and cleanup a bit around uuids xattrs: add space name extended attribute, as opposed to node name lint: redundancy ... lint: ... xattrs: comment on space.name add changelog spaces: a space creator becomes an editor within the new resource escape ldap filters (cs3org#2042) fix the storageid of shares (cs3org#2033) [Build-deps]: Bump github.com/go-chi/chi/v5 from 5.0.3 to 5.0.4 (cs3org#2038) Bumps [github.com/go-chi/chi/v5](https://github.com/go-chi/chi) from 5.0.3 to 5.0.4. - [Release notes](https://github.com/go-chi/chi/releases) - [Changelog](https://github.com/go-chi/chi/blob/master/CHANGELOG.md) - [Commits](go-chi/chi@v5.0.3...v5.0.4) --- updated-dependencies: - dependency-name: github.com/go-chi/chi/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [Build-deps]: Bump github.com/aws/aws-sdk-go from 1.40.17 to 1.40.37 (cs3org#2040) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.40.17 to 1.40.37. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.40.17...v1.40.37) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [Build-deps]: Bump go.opentelemetry.io/otel/sdk (cs3org#2039) Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.0.0-RC2 to 1.0.0-RC3. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.0.0-RC2...v1.0.0-RC3) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> runtime: do not truncate logs on reload (cs3org#2047) Bump core commit id (cs3org#2048) update cs3apis, add utility methods for share filters (cs3org#2044) Fail initialization if app is unsupported (cs3org#2034) Nextcloud storage integration tests & add Nextcloud drivers for auth and user (cs3org#2043)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mini PR to improve error handling when an app is not WOPI-compliant nor it is supported by the WOPI bridge extensions