Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locking fixes #2625

Merged
merged 19 commits into from
Mar 28, 2022
Merged

Locking fixes #2625

merged 19 commits into from
Mar 28, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Mar 9, 2022 •
edited
Loading

  • expire locks
  • pass lockid from the InitiateUploadRequest via metadata to the FinishUpload, so that we don't need to provide that info the the datagateway
  • enable lock modification for app based locks independently of the user
  • implement locking for public storage provider

@update-docs
Copy link

update-docs bot commented Mar 9, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek mentioned this pull request Mar 10, 2022
Closed
@wkloucek wkloucek marked this pull request as ready for review March 14, 2022 12:55
@wkloucek wkloucek requested review from a team, labkode, ishank011 and glpatcern as code owners March 14, 2022 12:55
@wkloucek wkloucek requested review from butonic, C0rby and kobergj and removed request for a team, labkode, glpatcern and ishank011 March 14, 2022 13:00
@glpatcern
Copy link
Member

@wkloucek some of those fixes are very relevant to master as well, shouldn't this be merged to master? or rather split the common part and keep in edge only the decomposedfs specifics?

@wkloucek wkloucek mentioned this pull request Mar 15, 2022
Merged
dragotin
dragotin approved these changes Mar 17, 2022
View reviewed changes
pkg/storage/utils/decomposedfs/node/locks.go Outdated Show resolved Hide resolved
pkg/storage/utils/decomposedfs/node/locks.go Show resolved Hide resolved
@wkloucek wkloucek marked this pull request as draft March 17, 2022 11:45
dragotin
dragotin approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@dragotin dragotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

pkg/storage/utils/decomposedfs/node/locks.go Show resolved Hide resolved
pkg/storage/utils/decomposedfs/node/locks.go Show resolved Hide resolved
@glpatcern glpatcern mentioned this pull request Mar 22, 2022
Merged
kobergj
kobergj requested changes Mar 23, 2022
View reviewed changes
pkg/storage/utils/decomposedfs/node/locks.go Outdated Show resolved Hide resolved
pkg/storage/utils/decomposedfs/node/locks.go Outdated Show resolved Hide resolved
@wkloucek wkloucek marked this pull request as ready for review March 25, 2022 09:24
@wkloucek wkloucek requested a review from kobergj March 25, 2022 09:25
kobergj
kobergj reviewed Mar 25, 2022
View reviewed changes
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 But lock tests are red...

@wkloucek
Copy link
Contributor Author

LGTM +1 But lock tests are red...

I fixed them in 520f58b

@wkloucek wkloucek merged commit 506516e into cs3org:edge Mar 28, 2022
@micbar micbar mentioned this pull request Mar 29, 2022
Closed
22 tasks
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpatcern glpatcern glpatcern left review comments

@dragotin dragotin dragotin approved these changes

@kobergj kobergj kobergj approved these changes

@butonic butonic Awaiting requested review from butonic

@C0rby C0rby Awaiting requested review from C0rby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wkloucek @glpatcern @dragotin @kobergj