Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wopi on edge #2721

Merged
merged 3 commits into from
Apr 8, 2022
Merged

wopi on edge #2721

merged 3 commits into from
Apr 8, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Apr 7, 2022

Bugfix: Fix locking and public link scope checker to make the WOPI server work

We've fixed the locking implementation to use the CS3api instead of the temporary opaque values.
We've fixed the scope checker on public links to allow the OpenInApp actions.

These fixes have been done to use the cs3org/wopiserver with REVA edge.

@update-docs
Copy link

update-docs bot commented Apr 7, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek changed the base branch from master to edge April 7, 2022 11:41
@wkloucek wkloucek marked this pull request as ready for review April 8, 2022 13:39
@wkloucek wkloucek requested review from labkode, ishank011, glpatcern and a team as code owners April 8, 2022 13:39
@wkloucek wkloucek requested review from C0rby and removed request for labkode, glpatcern and ishank011 April 8, 2022 13:39
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants