-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta ids #2793
Meta ids #2793
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
@@ -142,6 +142,9 @@ func (h *MetaHandler) handlePathForUser(w http.ResponseWriter, r *http.Request, | |||
Status: "HTTP/1.1 200 OK", | |||
Prop: []prop.PropertyXML{ | |||
prop.Escaped("oc:meta-path-for-user", pathRes.Path), | |||
prop.Escaped("oc:id", id), | |||
prop.Escaped("oc:fileid", id), | |||
prop.Escaped("oc:spaceid", rid.GetStorageId()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is space ID and StorageId really the same? Looks confusing to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
naming 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...can and should be changed to make the world less confusing....
Or? Are we talking about a space or a storage? IIRC that is a difference, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be discussed before we freeze the CS3Apis. StorageID was the property which was already there and we use it as the spaceID
Description
Add IDs to
dav/meta
response.