add request id to important http handlers #3376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbar
requested review from
a team,
labkode,
ishank011,
wkloucek and
glpatcern
as code owners
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
rhafer
reviewed
Oct 20, 2022
micbar
force-pushed
the
requestID
branch
2 times, most recently
from
1dfc6a7 to
c044d0c
Compare
micbar
commented
Oct 21, 2022
| @@ -191,8 +192,11 @@ func useMiddlewares(r *chi.Mux, sopts *Options, svc global.Service, tp trace.Tra | |||
| // ctx | |||
| cm := appctx.New(sopts.Logger, tp) | |||
|
|
|||
| // request-id | |||
| rm := middleware.RequestID | |||
There was a problem hiding this comment.
@rhafer Could not find another way. Any ideas? the ocdav service starts differently
C0rby
approved these changes
Oct 24, 2022
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add request-id to logs in