Fix some possible race conditions #3377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhafer
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
This was referenced Oct 19, 2022
When launching multiple reva instance for a single process we need to make sure that the sharedconfig global variable is initialized exactly once. Otherwise we might run into race conditions. Similarly make sure to initialize the user cache for the auth interceptor exactly once.
C0rby
approved these changes
Oct 20, 2022
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When launching multiple reva instance for a single process we need to make sure that the sharedconfig global variable is initialized exactly once. Otherwise we might run into race conditions. Similarly make sure to initialize the user cache for the auth interceptor exactly once.