Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong space editor permission #3934

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

micbar
Copy link
Member

@micbar micbar commented Jun 5, 2023

Description

A space editor should not have the permission to purge the trash bin.

@micbar micbar force-pushed the fix-editor-permissions branch from a20ddff to bd1178c Compare June 5, 2023 11:03
@micbar micbar marked this pull request as ready for review June 5, 2023 11:15
@micbar micbar requested review from a team, labkode, ishank011 and glpatcern as code owners June 5, 2023 11:15
@phil-davis
Copy link
Contributor

Various tests now fail, for example:
https://drone.owncloud.com/cs3org/reva/1697/12/6

Failed step: And as user "Brian" folder "/Shares/tmp" should contain a property "ocs:share-permissions" with value "15"
        Property "ocs:share-permissions" found with value "7", expected "#^15$#" or "#^15$#"

If this is the new requirement, then tests need adjusting. The "source" test scenarios are in ocis, so maybe the known-failing tests get added to expected-failures here with and issue raised in ocis. Then we adjust the test scenarios in ocis as we pull this code into ocis. Then we pull the updated ocis tests back into reva (and the expected-failures can be deleted)

@micbar
Copy link
Member Author

micbar commented Jun 5, 2023

@phil-davis There must be something wrong. That should not touch sharing at all.

@micbar micbar force-pushed the fix-editor-permissions branch from bd1178c to 082d238 Compare June 5, 2023 12:27
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good enough for me. Note that It won't affect existing space editors

@micbar micbar force-pushed the fix-editor-permissions branch from 082d238 to 950a0a1 Compare June 5, 2023 13:30
@micbar
Copy link
Member Author

micbar commented Jun 5, 2023

Let's see, there were some code changes missing. Now it should work and pass the testsuite.

@micbar micbar merged commit 0003b7f into cs3org:edge Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants