-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wrong space editor permission #3934
Conversation
a20ddff
to
bd1178c
Compare
Various tests now fail, for example:
If this is the new requirement, then tests need adjusting. The "source" test scenarios are in ocis, so maybe the known-failing tests get added to expected-failures here with and issue raised in ocis. Then we adjust the test scenarios in ocis as we pull this code into ocis. Then we pull the updated ocis tests back into reva (and the expected-failures can be deleted) |
@phil-davis There must be something wrong. That should not touch sharing at all. |
bd1178c
to
082d238
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Good enough for me. Note that It won't affect existing space editors
082d238
to
950a0a1
Compare
Let's see, there were some code changes missing. Now it should work and pass the testsuite. |
Description
A space editor should not have the permission to purge the trash bin.