Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enforce passwords on public share provider #4372

Merged
merged 5 commits into from
Dec 6, 2023
Merged

feat: enforce passwords on public share provider #4372

merged 5 commits into from
Dec 6, 2023

Conversation

micbar
Copy link
Member

@micbar micbar commented Nov 28, 2023 •
edited
Loading

Description

  • Add password validation to CreatePublicShare()
  • Add expiration date validation to CreatePublicShare()
  • Add permission check to RemovePublicShare()
  • Remove password validation from json share manager

@update-docs Update Docs
Copy link

update-docs bot commented Nov 28, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar micbar force-pushed the public-provider-pw branch 3 times, most recently from 8e7c024 to 340583a Compare November 29, 2023 21:32
@micbar micbar force-pushed the public-provider-pw branch 11 times, most recently from cc66295 to de1c439 Compare December 5, 2023 20:24
@micbar micbar force-pushed the public-provider-pw branch from de1c439 to 98cc80d Compare December 6, 2023 08:00
@micbar micbar requested a review from 2403905 December 6, 2023 08:01
@micbar micbar marked this pull request as ready for review December 6, 2023 08:01
@micbar micbar requested review from labkode, glpatcern and a team as code owners December 6, 2023 08:01
@micbar micbar requested review from fschade, kobergj and butonic December 6, 2023 08:01
@micbar micbar force-pushed the public-provider-pw branch 2 times, most recently from c4631a4 to 039e904 Compare December 6, 2023 08:22
@micbar micbar force-pushed the public-provider-pw branch from 039e904 to b15eeed Compare December 6, 2023 08:23
@micbar micbar requested a review from rhafer December 6, 2023 08:32
fschade
fschade approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 o 2 nitpicks, all optional!

LGTM 🎸

@micbar micbar requested a review from fschade December 6, 2023 10:25
@micbar micbar merged commit 7198abf into cs3org:edge Dec 6, 2023
9 checks passed
This was referenced Dec 6, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2403905 2403905 2403905 approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

@kobergj kobergj Awaiting requested review from kobergj

@butonic butonic Awaiting requested review from butonic

@rhafer rhafer Awaiting requested review from rhafer

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@micbar @2403905 @fschade