Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement OCM wellknown for discovery #4809

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Aug 14, 2024

The wellknown service now implements the /.well-known/ocm endpoint for OCM discovery. The unused endpoints for openid connect and webfinger have been removed. This aligns the wellknown implementation with the master branch.

Categorizing as 'Enhancement' because the existing service was unused in ocis.

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic butonic requested review from labkode, glpatcern and a team as code owners August 14, 2024 19:50
@butonic butonic self-assigned this Aug 14, 2024
@butonic butonic added the OCM Open Cloud Mesh label Aug 14, 2024
@glpatcern
Copy link
Member

Good you're looking after this @butonic ! but don't forget the legacy endpoint must remain.

And more in general: what about having a checkpoint meeting on what is pure OCM vs what is ScienceMesh etc.? I didn't receive any reply to my email in July but people should be back in the coming days. Let's sort out the details by email?

@butonic
Copy link
Contributor Author

butonic commented Aug 16, 2024

so ... discovery is only part of sciencemesh?

@glpatcern
Copy link
Member

so ... discovery is only part of sciencemesh?

how is that related to the wellknown endpoint? Anyway, discovery is part of OCM.

@butonic
Copy link
Contributor Author

butonic commented Aug 26, 2024

@glpatcern which legacy endpoints exactly? the old oidc and webfinger stups I removed?

👀

When a sending server allows sharing to any internet-hosted receiving server, then discovery can happen from the sharee address, using the /.well-known/ocm (or /ocm-provider, for backwards compatibility) URL that receiving servers SHOULD provide according to this specification.

Ah so you mean /ocm-provider? it should render the exact same content, right?

regarding a checkpoint meeting: that would be welcome ... need to find a timeslot ...

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@glpatcern
Copy link
Member

Ah so you mean /ocm-provider? it should render the exact same content, right?

Yes that's it.

regarding a checkpoint meeting: that would be welcome ... need to find a timeslot ...

I can revive the mail thread and propose some slots, we should all be back and it's hopefully easy to find one.

@butonic butonic removed their assignment Oct 2, 2024
@butonic butonic merged commit 2a6fdbe into cs3org:edge Oct 4, 2024
10 checks passed
@butonic butonic deleted the ocm-wellknown branch October 4, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCM Open Cloud Mesh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants