-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specific application/x-binary mime type for bin extension files to mime type mapping #4846
Conversation
… mimetype mapping
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@2403905 will take the review over. We are not sure this fixes it without side effects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We map the mime type to files by extension and not only bin
has type application/octet-stream
, there are bpk
, buffer
and etc. in a mimeTypes
map. We also set the application/octet-stream
to any files w/o extension.
I think we should take a look at the ListSupportedMimeTypes
I think the problem is here https://github.com/owncloud/ocis/blob/4d5168f6c3ab182db596c996e8b9090f4dedc55e/services/collaboration/pkg/helpers/registration.go#L41
The |
~~And then the files w/o a mapped extension<>mime type have no mime type anymore? I think the default is there on purpose. I am wondering why OnlyOffice and Collabora are configured to be able to open especially the application/ocet-stream mime type. Shouldn't we just avoid that ?~~ NVM, you are totally right, I think that ^ is especially what you are trying to achieve 💪 |
Fixed in a ocis |
Enhancement: Add specific mime type for bin files
We've added the specific mime type 'application/x-binary' for bin files to the list of mime types.