Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eosclient: handle empty traces #5028

Merged
merged 1 commit into from
Jan 7, 2025
Merged

eosclient: handle empty traces #5028

merged 1 commit into from
Jan 7, 2025

Conversation

labkode
Copy link
Member

@labkode labkode commented Jan 7, 2025 •
edited
Loading

Empty traces (i.e not defined in ctx) cause the eosclient to fail commands that set the --comment flag.

glpatcern
glpatcern approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting finding, thanks!

@glpatcern glpatcern merged commit cc2dd41 into master Jan 7, 2025
26 checks passed
@labkode labkode deleted the btrace branch January 7, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpatcern glpatcern glpatcern approved these changes

@diocas diocas Awaiting requested review from diocas diocas is a code owner

@jessegeens jessegeens Awaiting requested review from jessegeens jessegeens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkode @glpatcern