Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit SpaceMembershipExpired event #5051

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

bastianbeier
Copy link

Emit SpaceMembershipExpired event

Closes: owncloud/ocis#10919

@bastianbeier bastianbeier self-assigned this Jan 23, 2025
@bastianbeier bastianbeier requested review from a team, labkode and glpatcern as code owners January 23, 2025 12:02
@bastianbeier bastianbeier force-pushed the feat/issue-10919 branch 2 times, most recently from 513346f to de65b4f Compare January 23, 2025 12:09
@2403905
Copy link

2403905 commented Jan 23, 2025

An issue there is that the user whose access is expired will get an event until someone who still has access emit an event. Because he will be return there

return nil, errtypes.NotFound(fmt.Sprintf("space %s not found", n.ID))

@bastianbeier bastianbeier merged commit a9d72db into cs3org:edge Jan 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants