Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a storage template package to define the user home directory #510

Merged
merged 17 commits into from
Feb 26, 2020

Conversation

labkode
Copy link
Member

@labkode labkode commented Feb 13, 2020

This PR adds a new storage template package to manipulate storage layouts based on concrete and common types like a User.

The storage implementations (eos, owncloud, s3) will have a new configuration field: user_layout that if defined will be used for the storage path.

$reva ls /global/users/g/gonzalhu/
Documentation
$ reva ls /home/
Documentation

with config:

[grpc.services.storageprovider]
driver = "eos"
mount_path = "/home"
mount_id = "123e4567-e89b-12d3-a456-426655440000"
expose_data_server = true
data_server_url = "http://localhost:12001/data"
enable_home_creation = true

[grpc.services.storageprovider.drivers.eos]
namespace = "/eos/test/reva/users"
master_url = "root://xxxx.cern.ch"
enable_home = true
user_layout = "{{substr 0 1 .Username}}/{{.Username}}"

@labkode labkode changed the title Storage template package [WIP] Storage template package Feb 13, 2020
@labkode labkode mentioned this pull request Feb 13, 2020
@labkode labkode requested review from butonic, diocas and refs February 13, 2020 15:16
@labkode labkode changed the title [WIP] Storage template package Storage template package Feb 13, 2020
@labkode
Copy link
Member Author

labkode commented Feb 13, 2020

@madsi1m this simplifies the logic of pw and the layout that you did in only one place.

If you miss something we can add it to the UserData struct.

@madsi1m
Copy link
Contributor

madsi1m commented Feb 17, 2020

@labkode I like it!
Created a PR on your branch labkode#4

Copy link
Contributor

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

@labkode labkode changed the title Storage template package add a storage template package to define the user home directory Feb 26, 2020
@labkode labkode merged commit 81f1cb2 into cs3org:master Feb 26, 2020
@labkode labkode deleted the fix-home-layout branch February 26, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants