Integrate WOPI Bridge functionality #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added possible extensions of the CodiMD APIs
…lly be implemented on the CodiMD side
All context is now either in the WOPI lock or passed as GET parameters
- changed license to Apache, similar to the WOPI server - renamed components and variables
Also fixed some TODOs
Also included some fixes in the readonly logic. Most of the code is commented out though, cf. comments.
This relies on an extended feature of CodiMD contributed by @mic4ael.
A new /wopi/iop/registerapp endpoint has been implemented for the autodiscovery, but the logic is for now mostly hardcoded, to preserve the previous behavior until we transition to the new AppRegistry.
See cs3org/reva#1779 for more details The concept is that WOPI will not be responsible for the discovery, and the functionality is implemented in the WOPI driver of the Reva AppProvider. Eventually, the discovery.py module will be dropped.
glpatcern
force-pushed
the
bridge
branch
8 times, most recently
from
0fad236 to
45c7219
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This large PR merges the whole wopibridge repository with its history, and brings an important refactoring of the wopiserver code:
corefolderbridgefolder/wopi/iop/openinappendpoint is now available, which will be used by Reva once the AppProviders implement the discovery in place of the wopiserver (see Revamp Application Registry reva#1779)core/discovery.pyand is now deprecated: will be removed once Reva only uses the new endpoint