Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow depreciated bazel depset ops to be used #12

Merged
merged 1 commit into from
Jun 9, 2019

Conversation

cry
Copy link
Contributor

@cry cry commented Jun 9, 2019

See bazelbuild/intellij#445

The bazel build in gen_compile_commands.sh uses + to add to depsets
which was apparently depreciated with newer releases.

Original error:

ERROR: /Users/careyli/unsw/comp6771/lectures/week1/BUILD:8:1: in //bazel-compilation-database-0.3.4:aspects.bzl%compilation_database_aspect aspect on cc_binary rule //lectures/week1:factorial:
Traceback (most recent call last):
        File "/Users/careyli/unsw/comp6771/lectures/week1/BUILD", line 8
                //bazel-compilation-database-0.3.4:aspects.bzl%compilation_database_aspect(...)
        File "/Users/careyli/unsw/comp6771/bazel-compilation-database-0.3.4/aspects.bzl", line 185, in _compilation_database_aspect_impl
                compilation_db += dep[CompilationAspect].compilation_db
`+` operator on a depset is forbidden. See https://docs.bazel.build/versions/master/skylark/depsets.html for recommendations. Use --incompatible_depset_union=false to temporarily disable this check.
ERROR: Analysis of aspect '//bazel-compilation-database-0.3.4:aspects.bzl%compilation_database_aspect of //lectures/week1:factorial' failed; build aborted: Analysis of target '//lectures/week1:factorial' failed; build aborted
INFO: Elapsed time: 1.062s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (20 packages loaded, 618 targets configured)

Bazel version:

Build label: 0.26.1-homebrew
Build target: bazel-out/darwin-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Thu Jun 6 18:36:29 2019 (1559846189)
Build timestamp: 1559846189
Build timestamp as int: 1559846189

See bazelbuild/intellij#445

The bazel build in gen_compile_commands.sh uses + to add to depsets
which was apparently depreciated with newer releases.
@matts1 matts1 merged commit 7d87aaa into cs6771:master Jun 9, 2019
@cry cry deleted the allow-depreciated-depset branch June 10, 2019 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants