Move Bing specific formatting of data out of mixpanel utilities funct…

…ion. These should be decoupled.

BingUtilities/R/keyword_performance_data.r

@@ -14,7 +14,7 @@
 #' @examples
 #' keyword_performance_data(from=20151216, to=20151219)
 keyword_performance_data <- function(from=Sys.Date(), to=Sys.Date()) {
-  raw <- raw_keyword_performance_data(from, to)
+  raw <- BingUtilities::raw_keyword_performance_data(from, to)
   cleaned  <- BingUtilities::clean_raw_keyword_data(raw)
   return(cleaned)
 }

MixpanelUtilities/R/clean_completed_order_events.r

@@ -11,9 +11,5 @@ clean_completed_order_events  <- function(events_matrix){
 	events_data_frame  <- events_data_frame %>% rename(app_user_id = id)
 	events_data_frame  <- events_data_frame %>% mutate(app_user_id = as.numeric(as.character(app_user_id)))
 
-	#Clean up keywords info for future lookup of Keyword name with Keyword ID from Bing data.
-	events_data_frame <- events_data_frame %>% mutate(keyword_id = as.numeric(gsub("kwd-","",latest_ad_awkeyword)))
-	events_data_frame <- events_data_frame %>% select( -latest_ad_awkeyword )
-
 	return(events_data_frame)
 }

PowerSupplyUtilities/R/create_bing_event_log.r

@@ -21,6 +21,10 @@ create_bing_event_log <- function(from=Sys.Date(),
   ppc_events <- all_ppc_raw_completed_order_events( from = from, to = to )
   mixpanel_bing_conversions <- ppc_events[["bing"]]
   mixpanel_bing_conversions <- clean_completed_order_events(mixpanel_bing_conversions)
+  #Clean up keywords info for future lookup of Keyword name with Keyword ID from Bing data.
+  mixpanel_bing_conversions <- mixpanel_bing_conversions %>% 
+                               mutate(keyword_id = as.numeric(gsub("kwd-","",latest_ad_awkeyword))) %>%
+                               select(-latest_ad_awkeyword)
 
   ##### Retrieve Bing Spend/Click Data
   bing_keywords_data <- BingUtilities::keyword_performance_data(from=as.Date(from), to=as.Date(to))