Remove quality score. Unused and causing bug

csalvato · Jul 6, 2016 · dde826e · dde826e
1 parent 0387812
commit dde826e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/AdWordsUtilities/R/summarize_elog.r b/AdWordsUtilities/R/summarize_elog.r
@@ -20,7 +20,7 @@ summarize_elog <- function(elog_data_frame,
   return (summarize(elog_data_frame, 
                     cost = sum(cost, na.rm = TRUE),
                     average_position = weighted.mean(average_position,impressions, na.rm=TRUE),
-                    average_quality_score=ifelse(is.null(elog_data_frame$quality_score), NA, mean(quality_score, na.rm=TRUE)) ,
+                    #average_quality_score=ifelse(is.null(elog_data_frame$quality_score), NA, mean(quality_score, na.rm=TRUE)) ,
                     estimated_available_impressions = sum(impressions/est_search_impression_share, na.rm=TRUE),
                     impressions = sum(impressions, na.rm = TRUE),
                     # imp share is not wholly accurate because of the way the numbers are reported, but close enough. 

diff --git a/BingUtilities/R/summarize_elog.r b/BingUtilities/R/summarize_elog.r
@@ -19,7 +19,7 @@ summarize_elog <- function(elog_data_frame,
   require(dplyr)
   return (summarize(elog_data_frame, cost = sum(cost, na.rm = TRUE),
                     average_position = weighted.mean(average_position,impressions, na.rm=TRUE),
-                    average_quality_score=mean(quality_score, na.rm=TRUE),
+                    #average_quality_score=mean(quality_score, na.rm=TRUE),
                     impressions = sum(impressions, na.rm = TRUE),
                     #### Can't get impression share info from Bing (at least not in a way that CVS understands...?)
                     #estimated_available_impressions = sum(impressions/est_search_impression_share, na.rm=TRUE),