Cleanup repo (neo-project#350)

* Cleanup repo * updated issue links * updated changelog.md * update changelog.md * Updated bctklib * Ran code analyzers * Updated github action to use `macos-13` * added paths-ignore to pr.yml Updated paths-ignore on push.yml
cschuchardt88 · Nov 17, 2023 · 4eb0e0d · 4eb0e0d
1 parent 626206d
commit 4eb0e0d
Show file tree

Hide file tree

Showing 14 changed files with 33 additions and 164 deletions.
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -5,6 +5,11 @@ on:
     branches:
       - master
       - release/*
+    paths-ignore:
+      - '.gitignore'
+      - '.gitattributes'
+      - 'LICENSE'
+      - '**/*.md'
 
 jobs:
   pack:

diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml
@@ -6,9 +6,10 @@ on:
       - master
       - release/*
     paths-ignore:
-      - 'readme.md'
-      - 'CHANGELOG.md'
-      - 'docs/**'
+      - '.gitignore'
+      - '.gitattributes'
+      - 'LICENSE'
+      - '**/*.md'
 
 env:
   AZURE_ARTIFACTS_FEED_URL: https://nuget.pkg.github.com/neo-project/index.json

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -12,7 +12,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy: 
       matrix:
-        os: [macos-11, macos-12, ubuntu-20.04, ubuntu-22.04, windows-2019, windows-2022]
+        os: [macos-11, macos-12, macos-13, ubuntu-20.04, ubuntu-22.04, windows-2019, windows-2022]
     steps:
     - name: Checkout Code
       uses: actions/checkout@v3

diff --git a/.vscode/launch.json b/.vscode/launch.json
diff --git a/.vscode/settings.json b/.vscode/settings.json
diff --git a/.vscode/tasks.json b/.vscode/tasks.json
diff --git a/changelog.md b/changelog.md
@@ -17,13 +17,28 @@ may not exactly match a publicly released version.
 
 ### Added
 
-* WIF encoded private keys can be used to specify signing and non-signing accounts 
+* Option for private key on `create` or `wallet create` command (`WIF` or `HEX` formats)
+* `wallet create` command to batch files
+* Global directory to search for files; _Note: still can be used in current directory_
+  * Windows Path: `%USERPROFILE%\.neo-express`
+  * Linux Path: `$HOME/.neo-express`
+* autorun `setup.batch` on `create` command
+* WIF encoded private keys can be used to specify signing and non-signing accounts
 * `contract update` command
 
 ### Changed
 
-* use `UInt160.ToString` to write wallet account script hash to console in 
-  `wallet list` command  
+* use `UInt160.ToString` to write wallet account script hash to console in
+  `wallet list` command
+
+### Issues Fixed
+* [#254](https://github.com/neo-project/neo-express/issues/254) - issues transferring genesis funds
+* [#257](https://github.com/neo-project/neo-express/issues/257) - How to specify public key as argument for contract run?
+* [#307](https://github.com/neo-project/neo-express/issues/307) - getapplicationlog response differs from neo-cli
+* [#302](https://github.com/neo-project/neo-express/issues/302) - Fixed wording for contract download height
+* [#298](https://github.com/neo-project/neo-express/issues/298) - Wrong command color
+* [#320](https://github.com/neo-project/neo-express/pull/320) - neoxp help suggests help
+* [#254](https://github.com/neo-project/neo-express/issues/345) - Updated vulnerable & package dependencies
 
 ## [3.5] - 2023-01-03
 

diff --git a/dirs.proj b/dirs.proj
diff --git a/src/bctklib/bctklib.csproj b/src/bctklib/bctklib.csproj
@@ -4,18 +4,13 @@
         <DebugType>Embedded</DebugType>
         <EmbedUntrackedSources>true</EmbedUntrackedSources>
         <IncludeSymbols>true</IncludeSymbols>
-        <PackageIcon>ngdsea.png</PackageIcon>
-        <PackageId>Neo.BlockchainToolkit.Library</PackageId>
         <RootNamespace>Neo.BlockchainToolkit</RootNamespace>
         <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     </PropertyGroup>
 
     <PropertyGroup Condition="'$(CI)' == 'true'">
         <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
     </PropertyGroup>
-    <ItemGroup>
-        <None Include="../ngdsea.png" Pack="true" Visible="false" PackagePath="" />
-    </ItemGroup>
     <ItemGroup>
         <InternalsVisibleTo Include="test.bctklib" />
     </ItemGroup>
@@ -24,8 +19,8 @@
         <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="all" />
         <PackageReference Include="Nerdbank.Streams" Version="2.10.72" />
         <PackageReference Include="OneOf" Version="3.0.263" />
-        <PackageReference Include="rocksdb" Version="8.5.3.42578" />
-        <PackageReference Include="System.IO.Abstractions" Version="19.2.69" />
+        <PackageReference Include="rocksdb" Version="8.6.7.43630" />
+        <PackageReference Include="System.IO.Abstractions" Version="19.2.87" />
         <PackageReference Include="Neo.Cryptography.MPT" Version="$(NeoVersion)" />
         <PackageReference Include="Neo.Network.RPC.RpcClient" Version="$(NeoVersion)" />
     </ItemGroup>

diff --git a/src/bctklib/plugins/ToolkitRpcServer.cs b/src/bctklib/plugins/ToolkitRpcServer.cs
@@ -338,7 +338,7 @@ public static (string name, string symbol, byte decimals) GetTokenDetails(this D
                     return (name, symbol, decimals);
                 }
             }
-            return ("<Unknown>", "<UNK>", (byte)0);
+            return ("<Unknown>", "<UNK>", 0);
         }
 
         public static IEnumerable<ReadOnlyMemory<byte>> GetNep11Tokens(this DataCache snapshot, UInt160 asset, UInt160 address, ProtocolSettings settings)

diff --git a/src/neoxp/launch.ps1 b/src/neoxp/launch.ps1
diff --git a/src/ngdsea.png b/src/ngdsea.png
diff --git a/test/test.bctklib/ReadWriteStoreTests.cs b/test/test.bctklib/ReadWriteStoreTests.cs
@@ -318,7 +318,7 @@ public static IStore GetPopulatedNeoRocksDbStore(string path)
         var storeType = typeof(Neo.Plugins.Storage.RocksDBStore).Assembly
             .GetType("Neo.Plugins.Storage.Store");
         var storeCtor = storeType?.GetConstructor(new[] { typeof(string) });
-        var store = storeCtor?.Invoke(new object[] { (string)path }) as IStore;
+        var store = storeCtor?.Invoke(new object[] { path }) as IStore;
         if (store is null)
             throw new NullReferenceException(nameof(Neo.Plugins.Storage.RocksDBStore));
         return store;

diff --git a/test/test.bctklib/Utility.cs b/test/test.bctklib/Utility.cs
@@ -51,7 +51,7 @@ public static IStore CreateNeoRocksDb(string path)
         const string storeTypeName = "Neo.Plugins.Storage.Store";
         var storeType = typeof(Neo.Plugins.Storage.RocksDBStore).Assembly.GetType(storeTypeName);
         var storeCtor = storeType?.GetConstructor(new[] { typeof(string) });
-        var store = storeCtor?.Invoke(new object[] { (string)path }) as IStore;
+        var store = storeCtor?.Invoke(new object[] { path }) as IStore;
         if (store == null)
             throw new Exception($"Failed to create {storeTypeName} instance");
         return store;