Add capability of deriving sky temperature from weather file horizontal infrared radiation #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealkruis
requested changes
Jul 2, 2024
doc/src/records/top-members.md
Outdated
| @@ -532,6 +532,7 @@ DEFAULT, Default: tSky from weather file if available else Berdahl-Martin | |||
| BERDAHLMARTIN, Berdahl-Martin (tSky depends on dew point, cloud cover, and hour) | |||
| DRYBULB, tSky = dry-bulb temperature (for testing) | |||
| BLAST, Blast model (tSky depends on dry-bulb) | |||
| IRHORIZ, Experimental model that derives tSky for horizonal infrared data from the weather file (available on some EPW files only) | |||
There was a problem hiding this comment.
It's not experimental once it's merged.
There was a problem hiding this comment.
- Reworded.
- I don't agree that there can be no experimental models in merged code. New stuff has to be merged to allow external users to test.
Comment on lines
+387
to
+406
| //-------------------------------------------------------------------------- | ||
| #if defined( _DEBUG) | ||
| void WDHR::wd_WriteCSV( // data writer for ad-hoc exports | ||
| int jDayST, | ||
| int iH) const | ||
| { | ||
| static FILE* pF = NULL; // file | ||
| if (!pF) | ||
| { | ||
| const char* fName = "wdhr.csv"; | ||
| pF = fopen(fName, "wt"); | ||
| if (pF) | ||
| fprintf(pF, "doy,hr,tdb,dni,dhi,ghi\n"); | ||
| } | ||
| if (pF) | ||
| fprintf(pF, "%d,%d,%0.1f,%0.1f,%0.1f,%0.1f\n", | ||
| jDayST, iH, wd_db, wd_DNI, wd_DHI, wd_glrad); | ||
|
|
||
| } // WDHR::wd_WriteCSV | ||
| #endif |
There was a problem hiding this comment.
Not clear what this is or if it's intended to be merged. Looks like temporary test code?
There was a problem hiding this comment.
Left for possible future use.
src/wfpak.cpp
Outdated
Comment on lines
3096
to
3107
| #if 0 | ||
| // sky temp experiment | ||
| float tSkyIR = DegRtoF(pow( IrSItoIP( irhoriz)/sigmaSB, 0.25)); | ||
| float tSkyIR = DegRtoF(pow( IrSItoIP( irHoriz)/sigmaSB, 0.25)); | ||
| static FILE* pF = NULL; // file | ||
| if (!pF) | ||
| { | ||
| const char* fName = "tSky.csv"; | ||
| pF = fopen(fName, "wt"); | ||
| fprintf(pF, "yr,mon,day,hr,osc,tsc,tSky_CSE,tSky_IR\n"); | ||
| fprintf(pF, "yr,mon,day,hr,osc,tsc,tSky_CSE (F),tSky_IR (F)\n"); | ||
| } | ||
| fprintf(pF, "%d,%d,%d,%d,%0.1f,%0.1f,%0.1f,%0.1f\n", yr, m, d, h, osc, tsc, wd_tSky, tSkyIR); | ||
| #endif |
There was a problem hiding this comment.
Is this still an experiment? I imagine this can all be deleted now?
There was a problem hiding this comment.
Updated this code and left it in. We are not yet done with testing sky models.
nealkruis
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default, CSE derives sky temperature from total sky cover, dry-bulb temperature, and dew-point temperature using the Berdahl-Martin model.
This PR adds the capability of deriving sky temperature from horizontal infrared radiation available in (some) EPW files. The capability is preliminary -- missing weatherfile IR data is not detected / diagnosed.
Added an IRHORIZ case to test file wthr01.cse.
Updated documentation.