Skip to content
This repository has been archived by the owner on Feb 25, 2022. It is now read-only.

Remove unwanted app flash when deep-linking (Fixes https://github.com/csells/go_router/issues/139) #162

Merged
merged 2 commits into from
Nov 14, 2021

Conversation

lulupointu
Copy link
Contributor

See #139 (comment) for an extensive description of the issue and the fix.

All the tests are passing.

No breaking changes.

@csells csells changed the title Remove unwanting application when deep-linking (Fixes https://github.com/csells/go_router/issues/139) Remove unwanted app flash when deep-linking (Fixes https://github.com/csells/go_router/issues/139) Nov 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2021

Codecov Report

Merging #162 (3a63e34) into master (739ea57) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   67.93%   67.76%   -0.18%     
==========================================
  Files          12       12              
  Lines         393      394       +1     
==========================================
  Hits          267      267              
- Misses        126      127       +1     
Impacted Files Coverage Δ
lib/src/go_route_information_parser.dart 0.00% <0.00%> (ø)
lib/src/go_router_delegate.dart 78.05% <0.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 739ea57...3a63e34. Read the comment docs.

@lulupointu
Copy link
Contributor Author

I fixed the complaining lint. Can you try again @csells ?

@csells csells merged commit c5e1d12 into csells:master Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants