This repository has been archived by the owner on Feb 25, 2022. It is now read-only.
feat: add pushReplacement and pushReplacementNamed
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osaxma
force-pushed
the
push_replacement
branch
from
8c94ad2 to
af1afe5
Compare
|
I've been thinking about how to produce a more general-purpose API for getting the current stack of pages and replacing it completely, which would make doing things like pushing, replacing, popping, etc. as easy as grabbing the current stack, rearranging it to your heart's content and then handing it back to go_router. Until that happens, it's premature to take PRs like this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt for #188
Please let me know what you think.