Decouple Model classes from file management #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
pabloitu
force-pushed
the
10-decouple-model-classes-from-accessors-readers-and-fileartifact-management
branch
from
8755aab to
673f9d8
Compare
…s/storage. Models have a flag to re-stage. refac: Renamed ModelTree as ForecastRegistry and PathTree as ExperimentRegistry. Moved .dir() method to ForecastRegistry. Decoupled the get_source from the directory creation, which is now inside the model class. Removed dataclasses from Registries. Removed __call__ override for registry classes and replaced them with get_path(). Created an abc BaseFileRegistry, from which ExperimentRegistry and ForecastRegistry inherits. Removed query_gcmt, as it was included in pycsep. Renamed iter_attr() from Experiment.as_dict() to parse_nested_dict, and moved to utils.py. sty: used black and pydocstringformatter in main modules. build: Added pydocstringformatter options to .toml. tests: updated all unit tests with the new classes. fix: conda manager prints output live to shell.
pabloitu
force-pushed
the
10-decouple-model-classes-from-accessors-readers-and-fileartifact-management
branch
from
673f9d8 to
334c461
Compare
pabloitu
deleted the
10-decouple-model-classes-from-accessors-readers-and-fileartifact-management
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10