Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum versions of dependencies #169

Merged
merged 11 commits into from
Jan 22, 2025
Merged

Bump minimum versions of dependencies #169

merged 11 commits into from
Jan 22, 2025

Conversation

mx-moth
Copy link
Contributor

@mx-moth mx-moth commented Jan 21, 2025

This includes dropping support for Python 3.10 and introducing support for Python 3.13

@mx-moth mx-moth self-assigned this Jan 21, 2025
This includes dropping support for Python 3.10 and introducing support
for Python 3.13
@david-sh-csiro
Copy link
Collaborator

I've tried running it locally and everything appears to be working well and as expected. I did notice that the local tox configuration hasn't been updated to include running tests against 3.13. It also still includes python 3.10 as a target to test against. I'll be testing with MoVE shortly to verify if it works as expected.

@mx-moth
Copy link
Contributor Author

mx-moth commented Jan 22, 2025

Good catch on missing the tox.ini updates!

@david-sh-csiro
Copy link
Collaborator

Tested with MoVE running python 3.13, emsarray ran without issues and showed much improved triangulation performance from pull request #163.

@david-sh-csiro
Copy link
Collaborator

david-sh-csiro commented Jan 22, 2025

Found a few python 3.10 references that may need to be updated.

emsarray/pyproject.toml
Line 112

[tool.mypy]
python_version = "3.10"

Probably need to add 3.13 as well.
emsarray/scripts/update_pinned_dependencies.sh
Line 5
PYTHON_VERSIONS=('3.10' '3.11' '3.12')

The min_deps_check.py script now acts on its own advice and will update
requirements-minimum.txt automatically by invoking `pip-compile`. The
update_pinned_dependencies.sh script now invokes the min_deps_check.py
script.
@mx-moth mx-moth merged commit 754a12c into main Jan 22, 2025
15 checks passed
@mx-moth mx-moth deleted the python3.13 branch January 22, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants