Switch to use manifest-path for cargo multi #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bossmc
suggested changes
Oct 26, 2016
| // Take a clone of the commands so that the manifest can be passed to the | ||
| // cargo command, this is to any references to files in the output are relative | ||
| // to the current directory. | ||
| let mut commands = commands.clone(); |
There was a problem hiding this comment.
You can take commands by move to avoid having to do this clone.
| banner = banner + " " + arg; | ||
| } | ||
| } | ||
| let banner = format!("Executing {} {}", CARGO, commands.join(" ")); | ||
|
|
||
| announce(&banner); |
There was a problem hiding this comment.
Won't this be wrong? It won't have --manifest-file in it unlike the real deal.
|
|
||
| for arg in commands { | ||
| cargo_cmd.arg(arg); | ||
| } |
There was a problem hiding this comment.
Actually, can't you just do:
cargo_cmd,arg("--manifest-path");
cargo_cmd.arg(...path sruff...);
for arg in &commands {
cargo_cmd.arg(arg);
}
Then you don't need to own commands at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting the current directory, provide manifest-path to the command. This is to ensure that any references to files in the output are relative to the current directory.