Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

help enable source link for Newtonsoft.Json #307

Closed
ctaggart opened this issue Jan 10, 2018 · 10 comments
Closed

help enable source link for Newtonsoft.Json #307

ctaggart opened this issue Jan 10, 2018 · 10 comments

Comments

@ctaggart
Copy link
Owner

I created a pull request JamesNK/Newtonsoft.Json#1555.

Meanwhile, I uploaded a nupkg to try out.
https://www.myget.org/feed/Packages/sourcelink

You can try it out with the json branch in sourcelink-test:
https://github.com/ctaggart/sourcelink-test/tree/json

@ctaggart
Copy link
Owner Author

Here is a video demo using Visual Studio 2017 15.5.2:
https://youtu.be/gyRGhCQPkB4

@MagicAndre1981
Copy link

I added your feed to NuGet options, but I get an error when I try to browse your feed in VS2017 nuget management UI for available packages:

[source link enabled packages] 'doctype' is an unexpected token. The expected token is 'DOCTYPE'. Line 1, position 3.

@ctaggart
Copy link
Owner Author

@MagicAndre1981 That is a standard NuGet feed from myget. They have instructions here:
https://www.myget.org/feed/Details/sourcelink

It looks like this from Visual Studio 2017 15.5.2:
image

How I have it configured in VS:
image

@MagicAndre1981
Copy link

ok, got it working now. I was not able to open the instruction page as guest.

That experience was great 😍😍😍. Can you please enable it for SignalR Client 2.2.2, too? I have issues that I would like to debug easier.

@ctaggart
Copy link
Owner Author

@MagicAndre1981, glad you liked it. SignalR falls in the aspnet camp. You will need to ask them to enable source link. #173. Unfortunately, they are still trying to figure things out aspnet/Universe#131.

@MagicAndre1981
Copy link

ok, it would be still nice if you could provide such a package Microsoft.AspNet.SignalR.Client -Version 2.2.2-pdb until they provide it officially 😇

@MagicAndre1981
Copy link

Can you please help the Xamarin guys to use it? Their old school way sucks:

https://blog.xamarin.com/debugging-xamarin-forms/

@ctaggart
Copy link
Owner Author

@MagicAndre1981 good idea. xamarin/Xamarin.Forms#2165 That article is a great example of the steps required before enabling source link.

@ctaggart
Copy link
Owner Author

Looks like this is going to happen soon using https://github.com/dotnet/sourcelink
JamesNK/Newtonsoft.Json#1746

@ctaggart ctaggart reopened this Jun 22, 2018
@ctaggart
Copy link
Owner Author

My blog about this finally happening:
http://blog.ctaggart.com/2018/06/newtonsoftjson-enabling-source-link.html

@ctaggart ctaggart closed this as completed Mar 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants