Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

Unable to get sourcelink working with net461 TFM #332

Closed
fubar-coder opened this issue Apr 29, 2018 · 4 comments
Closed

Unable to get sourcelink working with net461 TFM #332

fubar-coder opened this issue Apr 29, 2018 · 4 comments

Comments

@fubar-coder
Copy link

fubar-coder commented Apr 29, 2018

Things I checked

  1. SourceLink V1 disabled
  2. SourceLink V2 enabled
  3. Tried with "Just my code" both enabled and disabled

Test I tried

  1. Create new-style csproj
  2. Used the NuGet Newtonsoft.Json package from https://www.myget.org/F/sourcelink/api/v3/index.json
  3. Tried to step into var output = JObject.Parse("{ \"a\": 1 }")

Result

Got a step-over instead of step-into.

Environment

  • Win10 Pro 1803
  • VS 2017 Community 15.6.7
@fubar-coder fubar-coder changed the title Unable to get sourcelink working Unable to get sourcelink working with net461 TFM Apr 29, 2018
@ctaggart
Copy link
Owner

If you pull down the Newtonsoft.Json package from nuget.org, it does not have SourceLink info yet. You can see #307 (comment) for a demo. I'm using a custom build of it that you can try. I uploaded it to a myget repo.

@fubar-coder
Copy link
Author

@ctaggart I already used your version from your myget feed. It works for .NET Core App 2.0, but not for .NET Framework.

@ctaggart
Copy link
Owner

ctaggart commented Jun 8, 2018

Can you try the next SourceLink version at https://github.com/dotnet/sourcelink ?

@ctaggart
Copy link
Owner

You can see examples of using the new Microsoft.SourceLink in #340 and #341

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants