This repository has been archived by the owner on Apr 16, 2020. It is now read-only.
add support for the GitLab SourceLinkServerType #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris5287
reviewed
Oct 12, 2017
| [InlineData("https://gitlab.com/ctaggart/sourcelink-test.git")] | ||
| [InlineData("https://gitlab.com/ctaggart/sourcelink-test")] | ||
| [InlineData("https://gitlab.com/ctaggart/sourcelink-test/")] | ||
| public void Should_return_url_in_canonical_form_for_GitLab(string provided) |
There was a problem hiding this comment.
Might be worth adding local GitLab urls as well to the tests?
There was a problem hiding this comment.
like also test against a gitlab.example.com domain?
|
@chris5287 I've updated the |
|
Thanks @rgl for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a copy of the GitHub code, but changed to work with GitLab hosted repositories.
I've opted for not restricting the repository url to a specific domain name like gitlab.com, it just accepts any, because in my/most cases it just references some internal domain name.
Fell free to ask for any change / rebase.