clippy

crates/rules/src/db.rs

@@ -122,11 +122,7 @@ impl From<Vec<(Origin, Entry)>> for DB {
 impl DB {
     /// Construct DB using the provided RuleDefs and associated sources
     pub(crate) fn from_sources(defs: Vec<(Origin, Entry)>) -> Self {
-        let model: BTreeMap<usize, DbEntry> = defs
-            .into_iter()
-            .enumerate()
-            .map(|(i, (source, d))| (i, (source, d)))
-            .collect();
+        let model: BTreeMap<usize, DbEntry> = defs.into_iter().enumerate().collect();
 
         let rules: BTreeMap<usize, RuleEntry> = model
             .iter()

crates/rules/src/load.rs

@@ -40,7 +40,7 @@ fn rules_file(path: PathBuf) -> Result<Vec<RuleSource>, io::Error> {
     let reader = File::open(&path).map(BufReader::new)?;
     let lines = reader
         .lines()
-        .flatten()
+        .map_while(Result::ok)
         .map(|s| (path.clone(), s))
         .collect();
     Ok(lines)

crates/rules/src/parser/trace.rs

@@ -52,16 +52,12 @@ impl<I: PartialEq> PartialEq for Trace<I> {
     }
 }
 
-///
-
 impl<I> Position for Trace<I> {
     fn position(&self) -> usize {
         self.position
     }
 }
 
-///
-
 impl<I: Offset> Offset for Trace<I> {
     fn offset(&self, second: &Self) -> usize {
         self.current.offset(&second.current)

crates/rules/src/read.rs

@@ -37,12 +37,12 @@ enum Line {
 enum LineError<I> {
     CannotParseSet(I, String),
     CannotParse(I, String),
-    Nom(I, ErrorKind),
+    Nom(I, ()),
 }
 
 impl<I> ParseError<I> for LineError<I> {
-    fn from_error_kind(input: I, kind: ErrorKind) -> Self {
-        LineError::Nom(input, kind)
+    fn from_error_kind(input: I, _kind: ErrorKind) -> Self {
+        LineError::Nom(input, ())
     }
 
     fn append(_: I, _: ErrorKind, other: Self) -> Self {