Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confluence API V2 uses string type for spaceId - Library uses int #247

Closed
abetterbuilder opened this issue Oct 6, 2023 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request

Comments

@abetterbuilder
Copy link

Is your feature request related to a problem? Please describe.
The v2 API documentation shows the POST body requiring a string for spaceId
Screenshot 2023-10-06 at 3 14 34 PM

However, type PageCreatePayloadSchema has SpaceID int which makes it impossible to send most requests as they use strings.

Describe the solution you'd like
Change:

type PageCreatePayloadScheme struct {
	SpaceID int                           `json:"spaceId,omitempty"`
	Status    string                        `json:"status,omitempty"`
	Title       string                        `json:"title,omitempty"`
	Body     *PageBodyRepresentationScheme `json:"body,omitempty"`
}

to:

type PageCreatePayloadScheme struct {
	SpaceID string                          `json:"spaceId,omitempty"`
	Status    string                        `json:"status,omitempty"`
	Title       string                        `json:"title,omitempty"`
	Body     *PageBodyRepresentationScheme `json:"body,omitempty"`
}
@abetterbuilder abetterbuilder added the enhancement New feature or request label Oct 6, 2023
abetterbuilder pushed a commit to abetterbuilder/go-atlassian that referenced this issue Oct 6, 2023
@abetterbuilder
Copy link
Author

Opened this PR to fix: #248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants