Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add watcher that is another user as this looks not implemented on Add() #291

Merged
merged 6 commits into from
Aug 3, 2024

Conversation

mur4s4m3
Copy link
Contributor

No description provided.

@Fank
Copy link
Collaborator

Fank commented Jul 20, 2024

@mur4s4m3 could you please also touch the tests, because they are currently failing.

jira/internal/watcher_impl.go Outdated Show resolved Hide resolved
jira/internal/watcher_impl.go Outdated Show resolved Hide resolved
jira/internal/watcher_impl.go Outdated Show resolved Hide resolved
service/jira/watcher.go Outdated Show resolved Hide resolved
@ctreminiom ctreminiom added enhancement New feature or request Jira Software Cloud V2 Jira Cloud V2 V3 Jira Cloud V3 breaking-change labels Jul 22, 2024
@mur4s4m3
Copy link
Contributor Author

tests fixed @Fank

@mur4s4m3
Copy link
Contributor Author

@Fank can you remove the "breaking change" label? It's no more true and wasn't removed by the pipeline.
Dunno if that's why it hasn't been merged yet.

@Fank
Copy link
Collaborator

Fank commented Jul 26, 2024

Done

@ctreminiom
Copy link
Owner

Thank you for your contributions, @mur4s4m3 and @Fank! This PR looks great. I'll go ahead and merge it now.

@ctreminiom ctreminiom merged commit c45d9ba into ctreminiom:main Aug 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Jira Software Cloud V2 Jira Cloud V2 V3 Jira Cloud V3
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

3 participants