fix: Empty conditions default false

ctrlplanedev · Oct 9, 2024 · e2b19bd · e2b19bd
1 parent fa49db9
commit e2b19bd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/apps/webservice/src/app/[workspaceSlug]/_components/EnvironmentDrawer.tsx b/apps/webservice/src/app/[workspaceSlug]/_components/EnvironmentDrawer.tsx
@@ -366,7 +366,7 @@ export const EnvironmentDrawer: React.FC = () => {
           {environment?.name}
         </DrawerTitle>
 
-        <div className="flex w-full gap-6 p-6">
+        <div className="flex w-full gap-6">
           {environment != null && workspace != null && (
             <div className="w-full space-y-12 overflow-auto">
               <EnvironmentForm environment={environment} />

diff --git a/packages/db/src/schema/release.ts b/packages/db/src/schema/release.ts
@@ -252,8 +252,7 @@ const buildCondition = (tx: Tx, cond: ReleaseCondition): SQL => {
   if (cond.type === ReleaseFilterType.Version)
     return buildVersionCondition(cond);
 
-  if (cond.conditions.length === 0 && cond.not) return sql`FALSE`;
-  if (cond.conditions.length === 0) return sql`TRUE`;
+  if (cond.conditions.length === 0) return sql`FALSE`;
 
   const subCon = cond.conditions.map((c) => buildCondition(tx, c));
   const con =

diff --git a/packages/db/src/schema/target.ts b/packages/db/src/schema/target.ts
@@ -174,8 +174,7 @@ const buildCondition = (tx: Tx, cond: TargetCondition): SQL => {
   if (cond.type === "name") return like(target.name, cond.value);
   if (cond.type === "provider") return eq(target.providerId, cond.value);
 
-  if (cond.conditions.length === 0 && cond.not) return sql`FALSE`;
-  if (cond.conditions.length === 0) return sql`TRUE`;
+  if (cond.conditions.length === 0) return sql`FALSE`;
 
   const subCon = cond.conditions.map((c) => buildCondition(tx, c));
   const con = cond.operator === "and" ? and(...subCon)! : or(...subCon)!;