fix: Use runtime envs and pass to fe #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsbroks
approved these changes
Aug 31, 2024
jsbroks
reviewed
Aug 31, 2024
| @@ -58,6 +70,8 @@ export const GithubOrgConfig: React.FC<{ | |||
| const [value, setValue] = useState<string | null>(null); | |||
| const [image, setImage] = useState<string | null>(null); | |||
|
|
|||
| const baseUrl = api.runtime.baseUrl.useQuery(); | |||
There was a problem hiding this comment.
Suggested change
| const baseUrl = api.runtime.baseUrl.useQuery(); | |
| const baseUrl = api.runtime.baseUrl.useQuery(); |
I though we would do something like runtime.useQuery() and it return an obj
jsbroks
reviewed
Aug 31, 2024
| userId?: string, | ||
| workspaceSlug?: string, | ||
| ) => | ||
| `${githubUrl}/login/oauth/authorize?response_type=code&client_id=${clientId}&redirect_uri=${baseUrl}/api/github/${userId}/${workspaceSlug}&state=sLtHqpxQ6FiUtBWJ&scope=repo%2Cread%3Auser`; |
There was a problem hiding this comment.
whats this state=sLtHqpxQ6FiUtBWJ
jsbroks
reviewed
Aug 31, 2024
Comment on lines
35
to
36
| const githubBotName = api.runtime.github.bot.name.useQuery(); | ||
| const githubBotClientId = api.runtime.github.bot.clientId.useQuery(); |
There was a problem hiding this comment.
Suggested change
| const githubBotName = api.runtime.github.bot.name.useQuery(); | |
| const githubBotClientId = api.runtime.github.bot.clientId.useQuery(); | |
| const{data: {name, clientId}} = api.runtime.github.bot.useQuery(); |
I would simplify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.