fix: Clean up release sequencing #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsbroks
reviewed
Oct 14, 2024
| envs: Array<{ id: string; policyId?: string | null }>, | ||
| ) => | ||
| envs.map((e) => ({ | ||
| id: `${e.policyId ?? "trigger"}-releaseSequencing-${e.id}`, |
There was a problem hiding this comment.
Suggested change
| id: `${e.policyId ?? "trigger"}-releaseSequencing-${e.id}`, | |
| id: `${e.policyId ?? "trigger"}-release-sequencing-${e.id}`, |
jsbroks
reviewed
Oct 14, 2024
| envs: Array<{ id: string; policyId?: string | null }>, | ||
| ) => | ||
| envs.map((e) => ({ | ||
| id: `${e.id}-releaseSequencing-${e.id}`, |
There was a problem hiding this comment.
Suggested change
| id: `${e.id}-releaseSequencing-${e.id}`, | |
| id: `${e.id}-release-sequencing-${e.id}`, |
jsbroks
reviewed
Oct 14, 2024
Comment on lines
+62
to
+71
| {isWaitingOnActive && ( | ||
| <> | ||
| <Waiting /> Another release is in progress | ||
| </> | ||
| )} | ||
| {!isWaitingOnActive && !allJobs.isLoading && ( | ||
| <> | ||
| <Passing /> All other releases finished | ||
| </> | ||
| )} |
jsbroks
reviewed
Oct 14, 2024
Comment on lines
36
to
52
| const jobsToCancelQuery = sql` | ||
| select distinct triggers.jobIdToCancel | ||
| from ${schema.releaseJobTrigger} | ||
| inner join ${schema.release} on ${schema.releaseJobTrigger.releaseId} = ${schema.release.id} | ||
| inner join ${schema.deployment} on ${schema.release.deploymentId} = ${schema.deployment.id} | ||
| inner join ${schema.environment} on ${schema.releaseJobTrigger.environmentId} = ${schema.environment.id} | ||
| inner join ${schema.environmentPolicy} on ${schema.environment.policyId} = ${schema.environmentPolicy.id} | ||
| inner join (${triggersSubquery}) as triggers on | ||
| ${schema.deployment.id} = triggers.cancelDeploymentId | ||
| and ${schema.releaseJobTrigger.environmentId} = triggers.cancelEnvironmentId | ||
| and ${schema.release.id} != triggers.cancelReleaseId | ||
| where ${inArray( | ||
| schema.releaseJobTrigger.id, | ||
| releaseJobTriggers.map((t) => t.id), | ||
| )} | ||
| and ${schema.environmentPolicy.releaseSequencing} = ${"cancel"} | ||
| `; |
There was a problem hiding this comment.
can you do this in drizzle, there is no way you cannot
jsbroks
reviewed
Oct 14, 2024
| ...envs.map((env) => { | ||
| const policy = policies.find((p) => p.id === env.policyId); | ||
| return { | ||
| id: env.id + "-releaseSequencing", |
There was a problem hiding this comment.
Suggested change
| id: env.id + "-releaseSequencing", | |
| id: env.id + "-release-sequencing", |
jsbroks
reviewed
Oct 14, 2024
| schema.releaseJobTrigger.id, | ||
| releaseJobTriggers.map((t) => t.id), | ||
| )} | ||
| and ${schema.environmentPolicy.releaseSequencing} = ${"cancel"} |
There was a problem hiding this comment.
can you use the enum value directly?
jsbroks
approved these changes
Oct 14, 2024
jsbroks
approved these changes
Oct 14, 2024
jsbroks
reviewed
Oct 14, 2024
| .execute(jobsToCancelQuery) | ||
| .then((r) => r.rows.map((r) => String(r.jobidtocancel))); | ||
|
|
||
| console.log("jobsToCancel", jobsToCancel); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.