feat: Update and Delete deployments with cascade, also lint fix #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsbroks
reviewed
Aug 27, 2024
jsbroks
reviewed
Aug 27, 2024
apps/webservice/src/app/[workspaceSlug]/_components/CreateDeployment.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Aug 27, 2024
apps/webservice/src/app/[workspaceSlug]/_components/CreateSystem.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Aug 27, 2024
apps/webservice/src/app/[workspaceSlug]/_components/DeleteDeployment.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Aug 27, 2024
apps/webservice/src/app/[workspaceSlug]/_components/DeploymentOptionsDropdown.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Aug 27, 2024
apps/webservice/src/app/[workspaceSlug]/_components/DeploymentOptionsDropdown.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Aug 27, 2024
apps/webservice/src/app/[workspaceSlug]/_components/DeploymentOptionsDropdown.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Aug 27, 2024
apps/webservice/src/app/[workspaceSlug]/_components/DeploymentOptionsDropdown.tsx
Show resolved
Hide resolved
jsbroks
reviewed
Aug 27, 2024
apps/webservice/src/app/[workspaceSlug]/_components/EditDeploymentDialog.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Aug 27, 2024
apps/webservice/src/app/[workspaceSlug]/_components/EditDeploymentDialog.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Aug 27, 2024
apps/webservice/src/app/[workspaceSlug]/_components/EditDeploymentDialog.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Aug 27, 2024
apps/webservice/src/app/[workspaceSlug]/_components/EditDeploymentDialog.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Aug 27, 2024
apps/webservice/src/app/[workspaceSlug]/_components/EditDeploymentDialog.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Aug 27, 2024
apps/webservice/src/app/[workspaceSlug]/_components/EditDeploymentDialog.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Aug 27, 2024
jsbroks
reviewed
Aug 27, 2024
jsbroks
reviewed
Aug 27, 2024
zacharyblasczyk
commented
Aug 27, 2024
| @@ -13,7 +13,7 @@ const buttonVariants = cva( | |||
| default: | |||
| "bg-primary text-primary-foreground shadow hover:bg-primary/90", | |||
| destructive: | |||
| "bg-destructive text-destructive-foreground shadow-sm hover:bg-destructive/90", | |||
| "bg-destructive text-destructive-foreground shadow-sm hover:bg-destructive/70", | |||
There was a problem hiding this comment.
Just a bit more visibility on hover.
zacharyblasczyk
commented
Aug 27, 2024
| @@ -7,6 +7,7 @@ packages: | |||
|
|
|||
| catalog: | |||
| eslint: ^9.9.0 | |||
| typescript-eslint: ^8.3.0 | |||
There was a problem hiding this comment.
Globalized this.
zacharyblasczyk
commented
Aug 27, 2024
| @@ -10,7 +10,7 @@ | |||
| "build": "turbo build", | |||
| "build:digitalocean": "pnpm install --production=false && pnpm build", | |||
| "clean": "git clean -xdf node_modules", | |||
| "clean:workspaces": "turbo clean", | |||
| "clean:workspaces": "turbo clean && find . -type d -name 'dist' -exec rm -rf {} +", | |||
There was a problem hiding this comment.
Helped with the dist being cached and causing an issue with pnpm db:push
zacharyblasczyk
commented
Aug 27, 2024
| @@ -32,6 +32,6 @@ | |||
| "prettier": "catalog:", | |||
| "tailwindcss": "catalog:", | |||
| "typescript": "catalog:", | |||
| "typescript-eslint": "^7.8.0" | |||
| "typescript-eslint": "catalog:" | |||
There was a problem hiding this comment.
different eslint across the project.
zacharyblasczyk
commented
Aug 27, 2024
Comment on lines
-17
to
+23
| "@next/eslint-plugin-next": "^14.2.3", | ||
| "eslint-config-turbo": "^1.13.3", | ||
| "@next/eslint-plugin-next": "^14.2.6", | ||
| "eslint-config-turbo": "^1.13.4", | ||
| "eslint-plugin-import": "^2.29.1", | ||
| "eslint-plugin-jsx-a11y": "^6.8.0", | ||
| "eslint-plugin-react": "^7.34.1", | ||
| "eslint-plugin-jsx-a11y": "^6.9.0", | ||
| "eslint-plugin-react": "^7.35.0", | ||
| "eslint-plugin-react-hooks": "beta", | ||
| "typescript-eslint": "^7.8.0" | ||
| "typescript-eslint": "^7.18.0" |
There was a problem hiding this comment.
Just a bump here.
Signed-off-by: Zachary Blasczyk <[email protected]>
jsbroks
reviewed
Aug 28, 2024
jsbroks
reviewed
Aug 28, 2024
apps/webservice/src/app/[workspaceSlug]/_components/EditDeploymentDialog.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Aug 28, 2024
apps/webservice/src/app/[workspaceSlug]/systems/[systemSlug]/deployments/TableDeployments.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Aug 29, 2024
zacharyblasczyk
commented
Aug 29, 2024
Comment on lines
+122
to
+131
| render={() => ( | ||
| <FormItem> | ||
| <FormLabel>ID</FormLabel> | ||
| <Input | ||
| value={id} | ||
| readOnly | ||
| className="bg-gray-800 text-gray-100" | ||
| /> | ||
| </FormItem> | ||
| )} |
There was a problem hiding this comment.
Doesn't need form control.
jsbroks
reviewed
Aug 29, 2024
apps/webservice/src/app/[workspaceSlug]/_components/DeleteDeployment.tsx
Show resolved
Hide resolved
zacharyblasczyk
commented
Aug 29, 2024
Comment on lines
54
to
55
| const onSubmit = form.handleSubmit(async (data) => { | ||
| const isDataChanged = !isEqual(data, { name, slug, description }); |
There was a problem hiding this comment.
Simplified this a bit.
jsbroks
reviewed
Aug 29, 2024
apps/webservice/src/app/[workspaceSlug]/_components/DeploymentOptionsDropdown.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Aug 29, 2024
apps/webservice/src/app/[workspaceSlug]/_components/EditDeploymentDialog.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Aug 29, 2024
apps/webservice/src/app/[workspaceSlug]/_components/EditDeploymentDialog.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Aug 29, 2024
|
|
||
| setOpen(false); | ||
| if (!isDataChanged) return; | ||
|
|
There was a problem hiding this comment.
probably add a check to make sure the slug is a valid slug?
There was a problem hiding this comment.
I will add that to linear.
RN we display this when you try and create a duplicate slug on any kind:
There was a problem hiding this comment.
The toast in the bottom left.
There was a problem hiding this comment.
this is only shown in dev mode, it will not happen in prod
jsbroks
reviewed
Aug 29, 2024
jsbroks
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to delete and edit deployments.