Upsert and Delete Views for Deployments and Systems. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyblasczyk
commented
Sep 27, 2024
zacharyblasczyk
commented
Sep 27, 2024
apps/webservice/src/app/[workspaceSlug]/_components/DeleteDeployment.tsx
Outdated
Show resolved
Hide resolved
|
|
|
jsbroks
reviewed
Sep 27, 2024
apps/webservice/src/app/[workspaceSlug]/_components/DeleteDeployment.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Sep 27, 2024
apps/webservice/src/app/[workspaceSlug]/systems/SystemActionsDropdown.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Sep 27, 2024
apps/webservice/src/app/[workspaceSlug]/systems/[systemSlug]/_components/DeleteSystemDialog.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Sep 27, 2024
apps/webservice/src/app/[workspaceSlug]/systems/[systemSlug]/_components/EditSystemDialog.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Sep 27, 2024
| setOpen(false); | ||
| }, | ||
| onError: () => { | ||
| form.setError("root", { |
There was a problem hiding this comment.
what if the error is something else?
There was a problem hiding this comment.
If you try and edit it and you haven't gotten the form correct, you will get this:
If it is another reason, I don't think we have a good pattern yet to show other messages.
jsbroks
reviewed
Sep 27, 2024
apps/webservice/src/app/[workspaceSlug]/systems/[systemSlug]/_components/DeleteSystemDialog.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Sep 27, 2024
apps/webservice/src/app/[workspaceSlug]/systems/[systemSlug]/_components/DeleteSystemDialog.tsx
Outdated
Show resolved
Hide resolved
jsbroks
reviewed
Sep 27, 2024
apps/webservice/src/app/[workspaceSlug]/systems/[systemSlug]/_components/EditSystemDialog.tsx
Outdated
Show resolved
Hide resolved
|
Lets but the actions in the navbar beside the deployment name |
zacharyblasczyk
commented
Sep 27, 2024
apps/webservice/src/app/[workspaceSlug]/_components/DeleteDeployment.tsx
Outdated
Show resolved
Hide resolved
apps/webservice/src/app/[workspaceSlug]/_components/DeleteDeployment.tsx
Outdated
Show resolved
Hide resolved
| })} | ||
| </BreadcrumbList> | ||
| </Breadcrumb> | ||
| <div> |
There was a problem hiding this comment.
@jsbroks can you look at this one
apps/webservice/src/app/[workspaceSlug]/systems/[systemSlug]/_components/DeleteSystemDialog.tsx
Outdated
Show resolved
Hide resolved
| @@ -51,6 +52,11 @@ export const DeploymentsNavBar: React.FC = () => { | |||
| </NavigationMenuItem> | |||
| </NavigationMenuList> | |||
| </NavigationMenu> | |||
| <div className="flex-grow items-center"> | |||
There was a problem hiding this comment.
the div is wrapping a component that conditionally renders, this mean sometimes we just have an empty div. is that what we want?
zacharyblasczyk
commented
Sep 27, 2024
| @@ -28,7 +28,7 @@ export const DeploymentOptionsDropdown: React.FC<{ | |||
| <> | |||
| <DropdownMenu> | |||
| <DropdownMenuTrigger asChild> | |||
| <Button size="icon" variant="ghost" className="rounded-full"> | |||
| <Button size="icon" variant="ghost"> | |||
There was a problem hiding this comment.
Aligning with our design elsewhere.
zacharyblasczyk
commented
Sep 27, 2024
| @@ -71,9 +71,7 @@ export const CreateDeploymentDialog: React.FC<{ | |||
|
|
|||
| watch((data, { name: fieldName }) => { | |||
| if (fieldName === "name") | |||
| setValue("slug", slugify(data.name ?? "", { lower: true }), { | |||
| shouldTouch: true, | |||
zacharyblasczyk
commented
Sep 27, 2024
Comment on lines
+142
to
+149
| <Button | ||
| type="submit" | ||
| disabled={ | ||
| form.formState.isSubmitting || !form.formState.isDirty | ||
| } | ||
| > | ||
| Save | ||
| </Button> |
There was a problem hiding this comment.
Let's me remove some complexity from the file.
|
@jsbroks ready for another review. |
jsbroks
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.