Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#29 - SSR ErrorComponent #43

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

DPr00f
Copy link

@DPr00f DPr00f commented Oct 30, 2017

As explained on #29 the Error component wasn't being rendered on the server side.
This PR fixes it.

@DPr00f
Copy link
Author

DPr00f commented Oct 31, 2017

Oh, I'll fix that today.

@codecov
Copy link

codecov bot commented Nov 1, 2017

Codecov Report

Merging #43 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   94.17%   94.33%   +0.16%     
==========================================
  Files           5        5              
  Lines         103      106       +3     
  Branches       31       31              
==========================================
+ Hits           97      100       +3     
  Misses          6        6
Impacted Files Coverage Δ
src/withJob.js 91.93% <100%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f99572...a26f579. Read the comment docs.

@DPr00f DPr00f mentioned this pull request Nov 6, 2017
@DPr00f
Copy link
Author

DPr00f commented Feb 6, 2018

Hey @ctrlplusb will this be considered at all?

Will be using this in production soon, would be nice to have this fixed.

@grahamd711
Copy link

Hi @ctrlplusb @DPr00f ! Thanks for reporting this issue. I ran into the same thing with the error component on SSR. Any updates if this is going to be resolved? Many thanks for all your work on this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants