Sourcery refactored master branch #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| input_dict = dict() | ||
| input_dict = {} |
There was a problem hiding this comment.
Function case_to_dict refactored with the following changes:
- Replace dict() with {}
| if not username or not password: | ||
| if not (username and password): |
There was a problem hiding this comment.
Function log_in refactored with the following changes:
- Simplify logical expression
| request.session['good_fields'] = dict() | ||
| request.session['good_fields'] = {} |
There was a problem hiding this comment.
Function create_account refactored with the following changes:
- Replace dict() with {}
Comment on lines
-108
to
+112
| if n == None: | ||
| if n is None: | ||
| n = len(X) | ||
|
|
||
| resample_i = np.floor(np.random.rand(n) * len(X)).astype(int) | ||
| X_resample = X[resample_i] | ||
| return X_resample | ||
| return X[resample_i] |
There was a problem hiding this comment.
Function bootstrap_resample refactored with the following changes:
- Inline variable that is only used once
- Use x is None rather than x == None
Comment on lines
-128
to
+134
|
|
||
| hours_slice, status_slice, category_slice = read_cases(filename) | ||
| print('Number of cases: {}'.format(len(hours_slice))) | ||
|
|
||
| # Key: category, value: list of (hours, status) points | ||
| category_map = group_by_category(hours_slice, status_slice, category_slice) | ||
| category_groups = list(get_category_groups(category_map)) | ||
|
|
There was a problem hiding this comment.
Function main refactored with the following changes:
- Replace list() with []
- Replace dict() with {}
- Replace list(), dict() or set() with comprehension
Comment on lines
-32
to
+36
| if n == None: | ||
| if n is None: | ||
| n = len(X) | ||
|
|
||
| resample_i = np.floor(np.random.rand(n) * len(X)).astype(int) | ||
| X_resample = X[resample_i] | ||
| return X_resample | ||
| return X[resample_i] |
There was a problem hiding this comment.
Function bootstrap_resample refactored with the following changes:
- Inline variable that is only used once
- Use x is None rather than x == None
|
Reviewed sourcery.ai changes and all seem good. Not tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: