Remove explicit g++ usage from Makefile #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Makefile for AGM explicitly used "g++" for the C++ compiler. This is undesirable, as it makes it more difficult to build on systems whose native compiler isn't GCC (FreeBSD and Mac OS X use Clang). This commit replaces the explicit use of "g++" with "$(CXX)", Make's normal variable that should have the default C++ compiler named in it. This can also be used to override which C++ compiler is being used, via "make CXX=<something else>".
|
Thanks @tvrusso ! Sorry to be so late on this - I wasn't watching pull requests because no one ever pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Makefile for AGM explicitly used "g++" for the C++ compiler. This
is undesirable, as it makes it more difficult to build on systems
whose native compiler isn't GCC (FreeBSD and Mac OS X use Clang).
This commit replaces the explicit use of "g++" with "$(CXX)", Make's
normal variable that should have the default C++ compiler named in
it. This can also be used to override which C++ compiler is being
used, via "make CXX=".