Change CPP variable to CXX, cleanup #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Makefile for SORAL used "$(CPP)" for the C++ compiler and "$(CPPFLAGS)" for the flags to pass to the compiler. This is nonstandard usage in Makefiles, where the CPP variable is used for the C preprocessor, and CPPFLAGS for the preprocessor flags. CXX is the usual variable for Makefiles to refer to the C++ compiler, and CXXFLAGS its associated flags variable. This commit brings the Makefile in line with more standard usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Makefile for SORAL used "$(CPP)" for the C++ compiler and
"$(CPPFLAGS)" for the flags to pass to the compiler. This is
nonstandard usage in Makefiles, where the CPP variable is used for the
C preprocessor, and CPPFLAGS for the preprocessor flags. CXX is the
usual variable for Makefiles to refer to the C++ compiler, and
CXXFLAGS its associated flags variable.
This commit brings the Makefile in line with more standard usage.