Skip to content

Commit

Permalink
Treat warnings as errors when running tests
Browse files Browse the repository at this point in the history
  • Loading branch information
tomwhite committed May 1, 2024
1 parent dd60506 commit 0f40520
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/beam-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@ jobs:
- name: Run tests
run: |
pytest -vs
pytest -vs -Werror
2 changes: 1 addition & 1 deletion .github/workflows/dask-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@ jobs:
- name: Run tests
run: |
pytest -vs
pytest -vs -Werror
2 changes: 1 addition & 1 deletion .github/workflows/jax-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: Run tests
run: |
# exclude tests that rely on structured types since JAX doesn't support these
pytest -k "not argmax and not argmin and not mean and not apply_reduction and not broadcast_trick and not groupby"
pytest -Werror -k "not argmax and not argmin and not mean and not apply_reduction and not broadcast_trick and not groupby"
env:
CUBED_BACKEND_ARRAY_API_MODULE: jax.numpy
JAX_ENABLE_X64: True
2 changes: 1 addition & 1 deletion .github/workflows/modal-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- name: Run tests
run: |
pytest -vs -k "test_modal.py or modal" --runcloud
pytest -vs -Werror -k "test_modal.py or modal" --runcloud
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/slow-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ jobs:
- name: Run tests
run: |
pytest -vs -k slow --runslow
pytest -vs -Werror -k slow --runslow
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ jobs:
- name: Run tests
run: |
if [ "$RUNNER_OS" == "Windows" ]; then
pytest -v
pytest -v -Werror
else
pytest -v --cov=cubed --cov-report=term-missing --cov-fail-under=90
pytest -v -Werror --cov=cubed --cov-report=term-missing --cov-fail-under=90
fi
shell: bash

0 comments on commit 0f40520

Please sign in to comment.