Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'disable bundler' scenarios to work with Bundler 2.4.17 and up #905

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Sep 1, 2023

Summary

Make the 'disable bundler' scenarios work with Bundler version 2.4.17 and up

Details

In recent versions of bundler, plain 'bundle' no longer prints a message for dependencies that were not updated. This change makes the scenarios use 'bundle list' instead, which should always keep printing all dependencies.

Motivation and Context

The relevent cucumber scenario started failing

How Has This Been Tested?

I ran the scenario again after the update to the code.

Types of changes

  • Internal change (refactoring, test improvements, developer experience or update of dependencies)

Checklist:

N/A

In recent versions of bundler, plain 'bundle' no longer prints a message
for dependencies that were not updated. This change makes the scenarios
use 'bundle list' instead, which should always keep printing all
dependencies.
@mvz mvz changed the title Update 'disable bundler' feature to work with Bundler 2.4.17 and up Update 'disable bundler' scenarios to work with Bundler 2.4.17 and up Sep 1, 2023
@mvz mvz merged commit 7e31af0 into main Sep 1, 2023
@mvz mvz deleted the fix-unbundling-scenario branch September 1, 2023 15:13
@mvz mvz mentioned this pull request Sep 1, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant