Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable ruby cck #960

Closed
aslakhellesoy opened this issue Apr 10, 2020 · 10 comments
Closed

Re-enable ruby cck #960

aslakhellesoy opened this issue Apr 10, 2020 · 10 comments
Assignees
Labels
language: ruby 🔧 build Related to build / release process

Comments

@aslakhellesoy
Copy link
Contributor

It was disabled recently because it won't pass until cucumber-ruby is updated to use the latest messages. Let's wait to do this until all the open messages issues/PRs have landed on master and we've made a new monorepo release.

@vincent-psarga
Copy link
Contributor

It'll have to wait for the next release of cucumber-ruby as this uses the released gems.

@stale
Copy link

stale bot commented Jun 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Jun 9, 2020
@aslakhellesoy
Copy link
Contributor Author

Bump @vincent-psarga

@stale stale bot removed the ⌛ stale Will soon be closed by stalebot unless there is activity label Jun 9, 2020
@stale
Copy link

stale bot commented Aug 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Aug 8, 2020
@aslakhellesoy
Copy link
Contributor Author

Bump @vincent-psarga

@stale stale bot removed the ⌛ stale Will soon be closed by stalebot unless there is activity label Aug 8, 2020
@aslakhellesoy
Copy link
Contributor Author

We should move compatibility-kit/ruby into the cucumber-ruby repo and run there. A failure in the ruby cck is a failure of cucumber-ruby, not the monorepo.

We can use the same approach as in Cucumber-JVM to copy over the golden messages:
https://github.com/cucumber/cucumber-jvm/blob/fa9085425282d1eacfc42eed4eee9e1b004ea9f4/Makefile#L21-L30

@aslakhellesoy
Copy link
Contributor Author

Reopening this again since it fails the build for some reason. We need to move this out of the monorepo and into cucumber-ruby.

@stale
Copy link

stale bot commented Dec 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Dec 15, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.

@stale stale bot closed this as completed Dec 25, 2020
@aslakhellesoy aslakhellesoy reopened this Apr 11, 2021
@stale stale bot removed the ⌛ stale Will soon be closed by stalebot unless there is activity label Apr 11, 2021
@luke-hill
Copy link
Contributor

Done above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language: ruby 🔧 build Related to build / release process
Projects
None yet
Development

No branches or pull requests

3 participants